gavinchou commented on code in PR #53675:
URL: https://github.com/apache/doris/pull/53675#discussion_r2219779912
##########
be/src/olap/rowset/segment_v2/binary_plain_page.h:
##########
@@ -75,12 +76,12 @@ class BinaryPlainPageBuilder : public
PageBuilderHelper<BinaryPlainPageBuilder<T
}
}
size_t offset = _buffer.size();
- _offsets.push_back(offset);
+ _offsets.push_back(static_cast<uint32_t>(offset));
// This may need a large memory, should return error if could not
allocated
// successfully, to avoid BE OOM.
RETURN_IF_CATCH_EXCEPTION(_buffer.append(src->data, src->size));
- _last_value_size = src->size;
+ _last_value_size = static_cast<uint32_t>(src->size);
Review Comment:
ditto, pls check other occurrences
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
