gavinchou commented on code in PR #53365:
URL: https://github.com/apache/doris/pull/53365#discussion_r2219075533
##########
cloud/src/meta-service/meta_service_partition.cpp:
##########
@@ -604,13 +604,20 @@ void
MetaServiceImpl::drop_partition(::google::protobuf::RpcController* controll
pb.SerializeToString(&to_save_val);
}
bool need_commit = false;
+ DropPartitionLogPB drop_partition_log;
+ drop_partition_log.set_db_id(request->db_id());
+ drop_partition_log.set_table_id(request->table_id());
+ drop_partition_log.mutable_index_ids()->CopyFrom(request->index_ids());
+ drop_partition_log.set_expiration(request->expiration());
Review Comment:
这个expiration就是另外一个评论里说到的历史遗留问题 不知道request 里到底是一个 duration 还是一个 timestamp,
以及单位也不确定...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
