gavinchou commented on code in PR #53570:
URL: https://github.com/apache/doris/pull/53570#discussion_r2218637435
##########
be/src/io/cache/block_file_cache.cpp:
##########
@@ -1847,7 +1847,8 @@ void BlockFileCache::check_need_evict_cache_in_advance() {
<< " inode_percent=" << inode_percentage << "
size_percent=" << size_percentage
<< " is_space_insufficient=" <<
is_insufficient(space_percentage)
<< " is_inode_insufficient=" <<
is_insufficient(inode_percentage)
- << " is_size_insufficient=" <<
is_insufficient(size_percentage)
+ << " is_size_insufficient="
+ << is_insufficient(static_cast<int>(size_percentage))
Review Comment:
ditto
##########
be/src/io/fs/file_handle_cache.cpp:
##########
@@ -148,7 +148,8 @@ Status FileHandleCache::get_file_handle(const hdfsFS& fs,
const std::string& fna
FileHandleCache::Accessor* accessor,
bool* cache_hit) {
DCHECK_GE(mtime, 0);
// Hash the key and get appropriate partition
- int index = HashUtil::hash(fname.data(), fname.size(), 0) %
_cache_partitions.size();
+ int index = HashUtil::hash(fname.data(), static_cast<int>(fname.size()),
0) %
Review Comment:
用 cast_set<>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
