yiguolei commented on code in PR #11940: URL: https://github.com/apache/doris/pull/11940#discussion_r953554584
########## be/src/olap/task/engine_storage_migration_task.cpp: ########## @@ -341,19 +290,10 @@ void EngineStorageMigrationTask::_generate_new_header( Status EngineStorageMigrationTask::_copy_index_and_data_files( const string& full_path, const std::vector<RowsetSharedPtr>& consistent_rowsets) const { - Status status = Status::OK(); for (const auto& rs : consistent_rowsets) { - status = rs->copy_files_to(full_path, rs->rowset_id()); - if (!status.ok()) { - Status ret = FileUtils::remove_all(full_path); Review Comment: This line is removed, then there exists garbage in this folder? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org