CalvinKirs commented on code in PR #53592:
URL: https://github.com/apache/doris/pull/53592#discussion_r2218105548
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/LoadCommand.java:
##########
@@ -493,12 +492,6 @@ public void checkS3Param() throws UserException {
}
}
}
- //should add connectivity test
- boolean connectivityTest =
FileSystemFactory.get(brokerDesc.getStorageProperties())
- .connectivityTest(filePaths);
- if (!connectivityTest) {
- throw new UserException("Failed to access object storage,
message=connectivity test failed");
- }
Review Comment:
Why skip connectivity checks? It's always better to fail fast when user
credentials are invalid. public access is the least commonly used
authentication method in production.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
