gavinchou commented on code in PR #53451:
URL: https://github.com/apache/doris/pull/53451#discussion_r2213503413
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/PublishVersionDaemon.java:
##########
@@ -246,8 +246,14 @@ private void tryFinishTxnAsync(TransactionState
transactionState, GlobalTransact
transactionState.getTransactionId(),
transactionState.getDbId(), transactionState.getTransactionId());
try {
dbExecutors.get((int) (transactionState.getDbId() %
Config.publish_thread_pool_num)).execute(() -> {
- tryFinishTxnSync(transactionState, globalTransactionMgr);
- publishingTxnIds.remove(transactionState.getTransactionId());
+ try {
+ tryFinishTxnSync(transactionState, globalTransactionMgr);
+
publishingTxnIds.remove(transactionState.getTransactionId());
+ } catch (Throwable e) {
+ LOG.warn("failed to finish transaction {}, dbId: {},
txnId: {}, exception: {}",
Review Comment:
多了最后一个{}
exception 会默认打印
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/PublishVersionDaemon.java:
##########
@@ -246,8 +246,14 @@ private void tryFinishTxnAsync(TransactionState
transactionState, GlobalTransact
transactionState.getTransactionId(),
transactionState.getDbId(), transactionState.getTransactionId());
try {
dbExecutors.get((int) (transactionState.getDbId() %
Config.publish_thread_pool_num)).execute(() -> {
- tryFinishTxnSync(transactionState, globalTransactionMgr);
- publishingTxnIds.remove(transactionState.getTransactionId());
+ try {
+ tryFinishTxnSync(transactionState, globalTransactionMgr);
+
publishingTxnIds.remove(transactionState.getTransactionId());
+ } catch (Throwable e) {
+ LOG.warn("failed to finish transaction {}, dbId: {},
txnId: {}, exception: {}",
Review Comment:
多了最后一个{}
exception 会默认打印, 不需要 placeholder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
