gavinchou commented on code in PR #53331:
URL: https://github.com/apache/doris/pull/53331#discussion_r2212747615
##########
be/src/io/fs/s3_file_writer.cpp:
##########
@@ -386,14 +387,14 @@ Status S3FileWriter::_complete() {
}
// check number of parts
- int expected_num_parts1 = (_bytes_appended / config::s3_write_buffer_size)
+
- !!(_bytes_appended %
config::s3_write_buffer_size);
- int expected_num_parts2 =
+ int64_t expected_num_parts1 = (_bytes_appended /
config::s3_write_buffer_size) +
+ !!(_bytes_appended %
config::s3_write_buffer_size);
+ int64_t expected_num_parts2 =
(_bytes_appended % config::s3_write_buffer_size) ? _cur_part_num :
_cur_part_num - 1;
DCHECK_EQ(expected_num_parts1, expected_num_parts2)
<< " bytes_appended=" << _bytes_appended << " cur_part_num=" <<
_cur_part_num
<< " s3_write_buffer_size=" << config::s3_write_buffer_size;
- if (_failed || _completed_parts.size() != expected_num_parts1 ||
+ if (_failed || _completed_parts.size() !=
static_cast<size_t>(expected_num_parts1) ||
Review Comment:
```suggestion
if (_failed || _completed_parts.size() !=
cast_set<size_t>(expected_num_parts1) ||
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
