This is an automated email from the ASF dual-hosted git repository.
gavinchou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 23170d69cc2 [fix](cloud) Fix roll-backed cumulative point of new
tablet when doing schema change (#53402)
23170d69cc2 is described below
commit 23170d69cc2d97f36036a62e911840e5838dfeb5
Author: Gavin Chou <[email protected]>
AuthorDate: Thu Jul 17 15:51:12 2025 +0800
[fix](cloud) Fix roll-backed cumulative point of new tablet when doing
schema change (#53402)
cumu point in job is from base tablet which may be fetched long time ago
since the new tablet may have done cumu compactions with alter_version
as initial cumu point
current cumu point of new tablet may be larger than job.alter_version
we need to keep the larger one in case of cumu point roll-back to
break the basic assumptions of non-decreasing cumu point
---
cloud/src/meta-service/meta_service.cpp | 3 ++-
cloud/src/meta-service/meta_service_job.cpp | 9 +++++++--
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/cloud/src/meta-service/meta_service.cpp
b/cloud/src/meta-service/meta_service.cpp
index b9faaa4a700..a2398ca3dbc 100644
--- a/cloud/src/meta-service/meta_service.cpp
+++ b/cloud/src/meta-service/meta_service.cpp
@@ -1820,8 +1820,9 @@ void
MetaServiceImpl::get_rowset(::google::protobuf::RpcController* controller,
code = MetaServiceCode::INVALID_ARGUMENT;
ss << "no valid compaction_cnt or cumulative_point given.
req_bc_cnt=" << req_bc_cnt
<< ", bc_cnt=" << bc_cnt << ", req_cc_cnt=" << req_cc_cnt << ",
cc_cnt=" << cc_cnt
- << ", req_cp=" << req_cp << ", cp=" << cp;
+ << ", req_cp=" << req_cp << ", cp=" << cp << " tablet_id=" <<
tablet_id;
msg = ss.str();
+ LOG(WARNING) << msg;
return;
}
auto versions = calc_sync_versions(req_bc_cnt, bc_cnt, req_cc_cnt,
cc_cnt, req_cp, cp,
diff --git a/cloud/src/meta-service/meta_service_job.cpp
b/cloud/src/meta-service/meta_service_job.cpp
index 1be1f640533..0fdcce32a26 100644
--- a/cloud/src/meta-service/meta_service_job.cpp
+++ b/cloud/src/meta-service/meta_service_job.cpp
@@ -1284,7 +1284,7 @@ void process_schema_change_job(MetaServiceCode& code,
std::string& msg, std::str
//==========================================================================
if (!schema_change.has_alter_version()) {
code = MetaServiceCode::INVALID_ARGUMENT;
- msg = "invalid alter_version";
+ msg = "no alter_version for schema change job, tablet_id=" +
std::to_string(tablet_id);
return;
}
if (schema_change.alter_version() < 2) {
@@ -1384,7 +1384,12 @@ void process_schema_change_job(MetaServiceCode& code,
std::string& msg, std::str
internal_get_tablet_stats(code, msg, txn.get(), instance_id,
new_tablet_idx, *stats,
detached_stats,
config::snapshot_get_tablet_stats);
// clang-format off
- stats->set_cumulative_point(schema_change.output_cumulative_point());
+ // ATTN: cumu point in job is from base tablet which may be fetched long
time ago
+ // since the new tablet may have done cumu compactions with
alter_version as initial cumu point
+ // current cumu point of new tablet may be larger than
job.alter_version
+ // we need to keep the larger one in case of cumu point roll-back to
+ // break the basic assumptions of non-decreasing cumu point
+
stats->set_cumulative_point(std::max(schema_change.output_cumulative_point(),
stats->cumulative_point()));
stats->set_num_rows(stats->num_rows() + (schema_change.num_output_rows() -
num_remove_rows));
stats->set_data_size(stats->data_size() +
(schema_change.size_output_rowsets() - size_remove_rowsets));
stats->set_num_rowsets(stats->num_rowsets() +
(schema_change.num_output_rowsets() - num_remove_rowsets));
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
