HappenLee commented on code in PR #11972:
URL: https://github.com/apache/doris/pull/11972#discussion_r952119405
##########
be/src/vec/columns/columns_common.cpp:
##########
@@ -106,14 +106,14 @@ struct ResultOffsetsBuilder {
void insertOne(size_t array_size) {
Review Comment:
change `insert_one`
##########
be/src/vec/columns/columns_common.cpp:
##########
@@ -106,14 +106,14 @@ struct ResultOffsetsBuilder {
void insertOne(size_t array_size) {
current_src_offset += array_size;
- res_offsets.push_back(current_src_offset);
+ res_offsets.push_back_without_reserve(current_src_offset);
}
template <size_t SIMD_BYTES>
void insertChunk(const IColumn::Offset* src_offsets_pos, bool first,
Review Comment:
same as up
##########
be/src/vec/columns/columns_common.cpp:
##########
@@ -151,15 +151,15 @@ void filter_arrays_impl_generic(const PaddedPODArray<T>&
src_elems,
LOG(FATAL) << "Size of filter doesn't match size of column.";
}
+ constexpr int assume_string_length = 5;
Review Comment:
ASSUME_STRING_LENGTH
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
