[GitHub] [doris] englefly commented on a diff in pull request #11812: [feature](Nereids) support non-equal predicates in Join

[GitBox]

englefly commented on code in PR #11812:
URL: https://github.com/apache/doris/pull/11812#discussion_r951277924


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/util/JoinUtils.java:
##########
@@ -51,14 +55,14 @@ public static boolean onlyShuffle(AbstractPhysicalJoin 
join) {
      */
     public static List<EqualTo> getEqualTo(AbstractPhysicalJoin<Plan, Plan> 
join) {
         List<EqualTo> eqConjuncts = Lists.newArrayList();
-        if (!join.getCondition().isPresent()) {
+        if (!join.getOtherJoinCondition().isPresent()) {
             return eqConjuncts;
         }
 
         List<SlotReference> leftSlots = 
Utils.getOutputSlotReference(join.left());
         List<SlotReference> rightSlots = 
Utils.getOutputSlotReference(join.right());
 
-        Expression onCondition = join.getCondition().get();
+        Expression onCondition = join.getOtherJoinCondition().get();

Review Comment:
   this function is not used. it is should be deleted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org