zclllyybb commented on code in PR #53314:
URL: https://github.com/apache/doris/pull/53314#discussion_r2207054354
##########
be/src/vec/functions/function_string.h:
##########
@@ -1586,10 +1586,8 @@ class FunctionStringFormatRound : public IFunction {
uint32_t result, size_t input_rows_count) const
override {
auto res_column = ColumnString::create();
ColumnPtr argument_column = block.get_by_position(arguments[0]).column;
- ColumnPtr argument_column_2;
- bool is_const;
Review Comment:
是不是把is_const作为模板参数传到`Impl::execute`更好一些？这个函数实际上第二个参数为literal还是比较常见的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
