cambyzju commented on code in PR #11894: URL: https://github.com/apache/doris/pull/11894#discussion_r950180856
########## be/src/exec/es/es_scroll_parser.h: ########## @@ -44,6 +44,9 @@ class ScrollParser { int get_size(); private: + Status fill_column(const TypeDescriptor slot_desc, vectorized::IColumn* col_ptr, Review Comment: ```suggestion Status fill_column(const TypeDescriptor& slot_desc, vectorized::IColumn* col_ptr, ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org