gavinchou commented on code in PR #53121:
URL: https://github.com/apache/doris/pull/53121#discussion_r2201460789
##########
cloud/src/resource-manager/resource_manager.cpp:
##########
@@ -444,7 +446,7 @@ std::pair<MetaServiceCode, std::string>
ResourceManager::add_cluster(const std::
return std::make_pair(cast_as<ErrCategory::COMMIT>(err), msg);
}
- add_cluster_to_index(instance_id, cluster.cluster);
+ refresh_instance(instance_id, instance);
Review Comment:
there (the original impl. also) may be a bug that before L499 is called
there could be another MS update the instancePB in KV, however the possibility
is very low:
1. call to L449 is very fast, in microsecs
2. the remote MS update will trigger a `refresh_signal` to all other
instance, which make all MS eventually consistent
CC @deardeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
