This is an automated email from the ASF dual-hosted git repository.
morrysnow pushed a commit to branch branch-3.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-3.1 by this push:
new 2662debe034 branch-3.1: [fix](job) fix show routine load job result
incorrect after alter job property #53038 (#53095)
2662debe034 is described below
commit 2662debe034ff61e3e22be6b8ca2e30fc70630cf
Author: github-actions[bot]
<41898282+github-actions[bot]@users.noreply.github.com>
AuthorDate: Fri Jul 11 13:54:41 2025 +0800
branch-3.1: [fix](job) fix show routine load job result incorrect after
alter job property #53038 (#53095)
Cherry-picked from #53038
Co-authored-by: hui lai <[email protected]>
---
.../main/java/org/apache/doris/load/routineload/RoutineLoadJob.java | 1 +
regression-test/suites/load_p0/routine_load/test_routine_load.groovy | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java
b/fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java
index fca306ad455..463b1dd4559 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java
@@ -2036,6 +2036,7 @@ public abstract class RoutineLoadJob
if
(jobProperties.containsKey(CreateRoutineLoadStmt.MAX_FILTER_RATIO_PROPERTY)) {
this.maxFilterRatio = Double.parseDouble(
jobProperties.remove(CreateRoutineLoadStmt.MAX_FILTER_RATIO_PROPERTY));
+
this.jobProperties.put(CreateRoutineLoadStmt.MAX_FILTER_RATIO_PROPERTY,
String.valueOf(maxFilterRatio));
}
if
(jobProperties.containsKey(CreateRoutineLoadStmt.MAX_BATCH_INTERVAL_SEC_PROPERTY))
{
diff --git
a/regression-test/suites/load_p0/routine_load/test_routine_load.groovy
b/regression-test/suites/load_p0/routine_load/test_routine_load.groovy
index 46c338e91a9..cf904f89cd5 100644
--- a/regression-test/suites/load_p0/routine_load/test_routine_load.groovy
+++ b/regression-test/suites/load_p0/routine_load/test_routine_load.groovy
@@ -1834,6 +1834,7 @@ suite("test_routine_load","p0") {
sql "ALTER ROUTINE LOAD FOR ${jobs[i]}
PROPERTIES(\"num_as_string\" = \"true\");"
sql "ALTER ROUTINE LOAD FOR ${jobs[i]}
PROPERTIES(\"fuzzy_parse\" = \"true\");"
sql "ALTER ROUTINE LOAD FOR ${jobs[i]}
PROPERTIES(\"workload_group\" = \"alter_routine_load_group\");"
+ sql "ALTER ROUTINE LOAD FOR ${jobs[i]}
PROPERTIES(\"max_filter_ratio\" = \"0.5\");"
res = sql "show routine load for ${jobs[i]}"
log.info("routine load job properties:
${res[0][11].toString()}".toString())
@@ -1844,8 +1845,7 @@ suite("test_routine_load","p0") {
assertEquals("300001", json.max_batch_rows.toString())
assertEquals("209715201", json.max_batch_size.toString())
assertEquals("6", json.max_batch_interval.toString())
- //TODO(bug): Can not update
- //assertEquals("0.5", json.max_filter_ratio.toString())
+ assertEquals("0.5", json.max_filter_ratio.toString())
assertEquals("jsonpaths", json.jsonpaths.toString())
assertEquals("json_root", json.json_root.toString())
assertEquals("true", json.strict_mode.toString())
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
