morrySnow commented on code in PR #53015:
URL: https://github.com/apache/doris/pull/53015#discussion_r2197105368
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/JsonObject.java:
##########
@@ -50,14 +50,13 @@ public JsonObject(Expression... varArgs) {
public FunctionSignature customSignature() {
List<DataType> arguments = new ArrayList<>();
for (int i = 0; i < arity(); i++) {
- if ((i & 1) == 1 && (getArgumentType(i).isComplexType() ||
getArgumentType(i).isJsonType())) {
- // keep origin type for BE Serialization
- arguments.add(JsonType.INSTANCE);
+ if (i % 2 == 1) {
+ arguments.add(getArgumentType(i));
} else {
arguments.add(VarcharType.SYSTEM_DEFAULT);
}
}
- return FunctionSignature.of(VarcharType.SYSTEM_DEFAULT, arguments);
+ return FunctionSignature.of(JsonType.INSTANCE, arguments);
Review Comment:
do we need to update exec_version since the return type has been changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
