morrySnow commented on code in PR #53037:
URL: https://github.com/apache/doris/pull/53037#discussion_r2196792310
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -1248,6 +1248,10 @@ relationHint
| HINT_START identifier (COMMA identifier)* HINT_END
#commentRelationHint
;
+expressionWithOrder
Review Comment:
add parser UT in `org.apache.doris.nereids.parser.NereidsParserTest` for
both postive and nagtive case
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -3379,6 +3381,21 @@ public OrderKey visitSortItem(SortItemContext ctx) {
});
}
+ /**
+ * get GroupKeyWithOrder
+ * @param ctx ExpressionWithOrderContext
+ * @return GroupKeyWithOrder
+ */
Review Comment:
remove this useless comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
