yiguolei commented on code in PR #52879:
URL: https://github.com/apache/doris/pull/52879#discussion_r2194342571


##########
be/src/pipeline/exec/olap_scan_operator.cpp:
##########
@@ -450,55 +449,72 @@ Status 
OlapScanLocalState::_init_scanners(std::list<vectorized::ScannerSPtr>* sc
     return Status::OK();
 }
 
-Status OlapScanLocalState::hold_tablets() {
-    if (!_tablets.empty()) {
+Status OlapScanLocalState::sync_cloud_tablets(RuntimeState* state) {
+    if (config::is_cloud_mode() && !_sync_tablet) {
+        _cloud_tablet_dependencies.resize(_scan_ranges.size());
+        for (size_t i = 0; i < _scan_ranges.size(); i++) {
+            _cloud_tablet_dependencies[i] =

Review Comment:
   不要这么多的dependency,比如如果查询10000个tablet,这里就会有10000个dependency,此时我们pipeline 
每次遍历的时候,就都得遍历一遍10000个,还是很废的。
   实际我们就是一个dependency,就是当所有的tablet 都sync之后



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to