Copilot commented on code in PR #52837:
URL: https://github.com/apache/doris/pull/52837#discussion_r2191328180
##########
regression-test/suites/nereids_arith_p0/load.groovy:
##########
@@ -106,6 +106,7 @@ suite("load") {
properties("replication_num" = "1")
"""
+ sql """ drop table IF EXISTS `expr_test_not_nullable2` """
Review Comment:
The DROP TABLE statement should end with a semicolon to ensure valid SQL
parsing, e.g., `drop table IF EXISTS expr_test_not_nullable2;`.
```suggestion
sql """ drop table IF EXISTS `expr_test_not_nullable2`; """
```
##########
regression-test/suites/nereids_tpch_p0/tpch/agg_cse.groovy:
##########
@@ -81,7 +81,7 @@ suite("agg_cse") {
select count(distinct k2,k3),count(*), sum(k2+k3), avg(k2+k3) from
nereids_test_query_db.baseall group by k1
"""
- contains("final projections: k1[#1], k2[#2], k3[#3], (k2[#2] +
k3[#3])")
+ contains("final projections: k1[#1], k2[#2], k3[#3], (CAST(k2[#2] AS
bigint) + CAST(k3[#3] AS bigint))")
// expect plan: final projections: k1[#1], k2[#2], k3[#3], (k2[#2] +
k3[#3])
Review Comment:
[nitpick] Update or remove this outdated commented expectation now that the
plan includes explicit `CAST` calls to avoid confusion.
```suggestion
// expect plan: final projections: k1[#1], k2[#2], k3[#3], (CAST(k2[#2]
AS bigint) + CAST(k3[#3] AS bigint))
```
##########
be/test/vec/exec/orc_reader_test.cpp:
##########
@@ -158,7 +158,7 @@ TEST_F(OrcReaderTest, test_build_search_argument) {
CANNOT_PUSH_DOWN_ERROR,
CANNOT_PUSH_DOWN_ERROR,
CANNOT_PUSH_DOWN_ERROR,
- CANNOT_PUSH_DOWN_ERROR,
+ //CANNOT_PUSH_DOWN_ERROR,
CANNOT_PUSH_DOWN_ERROR,
Review Comment:
[nitpick] This commented-out test element should be removed if no longer
relevant to keep the test data clean.
```suggestion
CANNOT_PUSH_DOWN_ERROR,
CANNOT_PUSH_DOWN_ERROR,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
