wyxxxcat commented on code in PR #52709:
URL: https://github.com/apache/doris/pull/52709#discussion_r2189940749
##########
cloud/src/recycler/recycler.cpp:
##########
@@ -2381,23 +2394,31 @@ int InstanceRecycler::recycle_rowsets() {
return 0;
}
if (!rowset.has_type()) {
- if (!rowset.has_resource_id()) [[unlikely]] {
- return 0;
- }
- if (rowset.resource_id().empty()) [[unlikely]] {
+ if (!rowset.has_resource_id() || rowset.resource_id().empty())
[[unlikely]] {
Review Comment:
这里是把两个分支合并了
```
if (!rowset.has_resource_id()) [[unlikely]] {
return -1;
}
if (rowset.resource_id().empty()) [[unlikely]] {
return -1;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
