Kikyou1997 commented on code in PR #11802:
URL: https://github.com/apache/doris/pull/11802#discussion_r946858640
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/Substring.java:
##########
@@ -18,19 +18,30 @@
package org.apache.doris.nereids.trees.expressions.functions;
import org.apache.doris.nereids.trees.expressions.Expression;
-import org.apache.doris.nereids.trees.expressions.IntegerLiteral;
-import org.apache.doris.nereids.trees.expressions.TernaryExpression;
+import org.apache.doris.nereids.trees.expressions.literal.IntegerLiteral;
+import org.apache.doris.nereids.trees.expressions.shape.TernaryExpression;
+import
org.apache.doris.nereids.trees.expressions.typecoercion.ImplicitCastInputTypes;
import org.apache.doris.nereids.types.DataType;
+import org.apache.doris.nereids.types.IntegerType;
import org.apache.doris.nereids.types.StringType;
+import org.apache.doris.nereids.types.coercion.AbstractDataType;
+import org.apache.doris.nereids.types.coercion.TypeCollection;
import com.google.common.base.Preconditions;
+import com.google.common.collect.ImmutableList;
import java.util.List;
/**
* substring function.
*/
-public class Substring extends BoundFunction implements TernaryExpression {
+public class Substring extends BoundFunction implements TernaryExpression,
ImplicitCastInputTypes {
+
+ private static final List<AbstractDataType> EXPECTED_INPUT_TYPES =
ImmutableList.of(
Review Comment:
comment pls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
