yiguolei commented on code in PR #52676:
URL: https://github.com/apache/doris/pull/52676#discussion_r2184075607
##########
be/src/vec/data_types/serde/data_type_bitmap_serde.cpp:
##########
@@ -194,23 +194,43 @@ Status DataTypeBitMapSerDe::write_column_to_orc(const
std::string& timezone, con
std::vector<StringRef>&
buffer_list) const {
auto& col_data = assert_cast<const ColumnBitmap&>(column);
orc::StringVectorBatch* cur_batch =
dynamic_cast<orc::StringVectorBatch*>(orc_col_batch);
-
- INIT_MEMORY_FOR_ORC_WRITER()
-
+ // First pass: calculate total memory needed and collect serialized values
+ size_t total_size = 0;
for (size_t row_id = start; row_id < end; row_id++) {
if (cur_batch->notNull[row_id] == 1) {
auto bitmap_value =
const_cast<BitmapValue&>(col_data.get_element(row_id));
size_t len = bitmap_value.getSizeInBytes();
-
- REALLOC_MEMORY_FOR_ORC_WRITER()
-
+ total_size += len;
Review Comment:
可能，每次都是 + len + 1
https://cplusplus.com/reference/cstring/strcpy/ 后面的strycpy 会拷贝最后一个null 字符串
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
