zclllyybb commented on code in PR #51683:
URL: https://github.com/apache/doris/pull/51683#discussion_r2183536339


##########
regression-test/suites/query_p0/sql_functions/json_functions/test_json_function.groovy:
##########
@@ -91,4 +91,10 @@ suite("test_json_function", "arrow_flight_sql") {
     qt_sql """select get_json_string('{"name\\k" : 123}', '\$.name\\k')"""
     qt_sql """select get_json_string('{"name\\k" : 123}', '\$.name\\\\k')"""
     qt_sql """select get_json_string('{"name\\k" : 123}', '\$.name\\\\\\k')"""
+
+    qt_sql """ SELECT JSON_MERGE_PATCH('[]','[]') """

Review Comment:
   有更多场景需要覆盖:
   1. value为null且key只出现过这一次
   2. 嵌套层级更深的json,内部的key相同,以及整个相同,等等
   3. 空字符串以及null
   and more



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to