yiguolei commented on code in PR #52676:
URL: https://github.com/apache/doris/pull/52676#discussion_r2181606318
##########
be/src/vec/data_types/serde/data_type_ipv6_serde.cpp:
##########
@@ -213,9 +213,9 @@ Status DataTypeIPv6SerDe::write_column_to_orc(const
std::string& timezone, const
for (size_t row_id = start; row_id < end; row_id++) {
if (cur_batch->notNull[row_id] == 1) {
auto serialized_value = IPv6Value::to_string(col_data[row_id]);
- size_t len = serialized_value.length();
- total_size += len;
serialized_values.push_back(serialized_value);
Review Comment:
这里得std move吧？或者
serialized_values.emplace_back(IPv6Value::to_string(col_data[row_id]););
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
