w41ter commented on code in PR #52405:
URL: https://github.com/apache/doris/pull/52405#discussion_r2178849454
##########
gensrc/proto/cloud.proto:
##########
@@ -1075,18 +1217,25 @@ message CreateInstanceResponse {
message AlterInstanceRequest {
enum Operation {
- UNKNOWN = 0;
- DROP = 1;
- REFRESH = 2;
- RENAME = 3;
- ENABLE_SSE = 4;
- DISABLE_SSE = 5;
- SET_OVERDUE = 6;
- SET_NORMAL = 7;
+ UNKNOWN = 0;
+ DROP = 1;
+ REFRESH = 2;
+ RENAME = 3;
+ ENABLE_SSE = 4;
+ DISABLE_SSE = 5;
+ SET_OVERDUE = 6;
+ SET_NORMAL = 7;
+ SNAPSHOT_SWITCH_ON = 8;
+ SNAPSHOT_SWITCH_OFF = 9;
+ WRITE_MULTI_VERSION_KEYS = 10;
+ READ_MULTI_VERSION_KEYS = 11;
+ DISABLE_SINGLE_VERSION_KEYS = 12;
+ SET_SNAPSHOT_PROPERTY = 13;
}
optional string instance_id = 1;
optional Operation op = 2;
optional string name = 3;
+ optional string value = 4;
Review Comment:
`SET_SNAPSHOT_PROPERTY` needs a value.
For example: `ALTER CLUSTER SNAPSHOT SET ("snapshot_interval" = "100")`
=>
AlterInstanceRequest { op: SET_SNAPSHOT_PROPERTY, name: "snapshot_interval",
value: "100" }
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
