HappenLee commented on code in PR #52452:
URL: https://github.com/apache/doris/pull/52452#discussion_r2173167875


##########
be/src/vec/columns/column_array.cpp:
##########
@@ -241,6 +243,154 @@ int ColumnArray::compare_at(size_t n, size_t m, const 
IColumn& rhs_, int nan_dir
     return lhs_size < rhs_size ? -1 : (lhs_size == rhs_size ? 0 : 1);
 }
 
+size_t ColumnArray::get_max_row_byte_size() const {
+    DCHECK(!data->is_variable_length());
+    size_t max_size = 0;
+    size_t num_rows = size();
+    for (size_t i = 0; i < num_rows; ++i) {
+        max_size = std::max(max_size, size_at(i));
+    }
+
+    return sizeof(size_t) + max_size * data->get_max_row_byte_size();
+}
+
+StringRef ColumnArray::get_data_at(size_t n) const {

Review Comment:
   the call seem only valid in fix length nested column? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to