yiguolei commented on code in PR #11647: URL: https://github.com/apache/doris/pull/11647#discussion_r943074677
########## be/src/olap/in_list_predicate.h: ########## @@ -76,9 +76,11 @@ struct equal_to<doris::uint24_t> { namespace doris { -template <class T, PredicateType PT> +template <PrimitiveType Type, PredicateType PT> class InListPredicateBase : public ColumnPredicate { public: + using T = std::conditional_t<Type == TYPE_DATE, uint24_t, Review Comment: We should unify CppType ---> PrimitiveType relation. Pls do not define them everywhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org