gavinchou commented on code in PR #49456:
URL: https://github.com/apache/doris/pull/49456#discussion_r2162849667


##########
be/src/io/cache/block_file_cache.h:
##########
@@ -489,6 +518,21 @@ class BlockFileCache {
                                std::lock_guard<std::mutex>& cache_lock, 
size_t& cur_removed_size,
                                bool evict_in_advance);
 
+    void record_queue_event(CacheLRULogQueue& log_queue, CacheLRULogType 
log_type,

Review Comment:
   add sufficient comment for all newly added functions, including params



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to