Baymine opened a new pull request, #51993:
URL: https://github.com/apache/doris/pull/51993

   ### What problem does this PR solve?
   
   Issue Number: close #xxx
   
   Related PR: #xxx
   
   Problem Summary:
   This PR adds support for multiple distinct operations with `collect_list` 
and `array_agg` functions. Previously, queries with multiple distinct 
`collect_list` or `array_agg` operations would fail with the error: 
`"collect_list(DISTINCT CASE WHEN ... THEN ... END) can't support multi 
distinct."` This limitation prevented users from using these functions in 
complex analytical queries that required multiple distinct aggregations.
   
   The implementation includes:
   1. **Frontend Changes**: Added `CollectList` and `ArrayAgg` to the supported 
functions list in `CheckMultiDistinct.java`
   2. **Multi-Distinct Function Classes**: Created `MultiDistinctCollectList` 
and `MultiDistinctArrayAgg` classes
   3. **Conversion Logic**: Added conversion methods to transform distinct 
functions to their multi-distinct versions
   4. **Backend Registration**: Registered the new multi-distinct functions in 
the backend aggregate function registry
   5. **Function Definitions**: Added function signatures in `FunctionSet.java`
   
   ### Release note
   
   **New Feature**: Added support for multiple distinct operations with 
`collect_list` and `array_agg` functions. Users can now use multiple distinct 
`collect_list` and `array_agg` operations in the same query without 
encountering the "can't support multi distinct" error.
   
   Example queries that now work:
   ```sql
   SELECT 
     group_id,
     collect_list(DISTINCT CASE WHEN condition1 = 1 THEN value END) as list1,
     collect_list(DISTINCT CASE WHEN condition2 = 'A' THEN value END) as list2,
     array_agg(DISTINCT CASE WHEN condition1 = 1 THEN value END) as agg1,
     array_agg(DISTINCT CASE WHEN condition2 = 'A' THEN value END) as agg2
   FROM table_name
   GROUP BY group_id;
   ```
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [x] Regression test
       - [x] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [x] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: 
https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should 
merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to