yiguolei commented on code in PR #51878:
URL: https://github.com/apache/doris/pull/51878#discussion_r2156300169
##########
be/src/pipeline/task_queue.cpp:
##########
@@ -77,6 +77,7 @@ PipelineTaskSPtr
PriorityTaskQueue::_try_take_unprotected(bool is_steal) {
if (task) {
task->update_queue_level(level);
_total_task_size--;
+ DorisMetrics::instance()->pipeline_task_queue_size->increment(-1);
Review Comment:
void PriorityTaskQueue::close() {
std::unique_lock<std::mutex> lock(_work_size_mutex);
_closed = true;
_wait_task.notify_all();
}
需要在close的时候，把剩余的在queue 中的task的数量减掉。 否则在workload group 创建和删除的时候，这个监控指标容易错误。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
