zhangstar333 commented on code in PR #51913:
URL: https://github.com/apache/doris/pull/51913#discussion_r2156234258
##########
be/src/vec/functions/function_java_udf.cpp:
##########
@@ -105,18 +105,21 @@ Status JavaFunctionCall::execute_impl(FunctionContext*
context, Block& block,
{"meta_address", std::to_string((long)input_table.get())},
{"required_fields", input_table_schema.first},
{"columns_types", input_table_schema.second}};
- jobject input_map = JniUtil::convert_to_java_map(env, input_params);
+ jobject input_map = nullptr;
+ RETURN_IF_ERROR(JniUtil::convert_to_java_map(env, input_params,
&input_map));
auto output_table_schema = JniConnector::parse_table_schema(&block,
{result}, true);
std::string output_nullable =
block.get_by_position(result).type->is_nullable() ? "true" :
"false";
std::map<String, String> output_params = {{"is_nullable", output_nullable},
{"required_fields",
output_table_schema.first},
{"columns_types",
output_table_schema.second}};
- jobject output_map = JniUtil::convert_to_java_map(env, output_params);
+ jobject output_map = nullptr;
+ RETURN_IF_ERROR(JniUtil::convert_to_java_map(env, output_params,
&output_map));
long output_address = env->CallLongMethod(jni_ctx->executor,
jni_ctx->executor_evaluate_id,
input_map, output_map);
- env->DeleteLocalRef(input_map);
- env->DeleteLocalRef(output_map);
+ RETURN_ERROR_IF_EXC(env);
Review Comment:
should delete, then check error to return
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
