924060929 commented on code in PR #51700: URL: https://github.com/apache/doris/pull/51700#discussion_r2153596172
########## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/InitMaterializationContextHook.java: ########## @@ -199,12 +209,17 @@ private List<MaterializationContext> createAsyncMaterializationContext(CascadesC // so regenerate the struct info table bitset StructInfo mvStructInfo = mtmvCache.getStructInfo(); BitSet tableBitSetInCurrentCascadesContext = new BitSet(); - mvStructInfo.getRelations().forEach(relation -> tableBitSetInCurrentCascadesContext.set( - cascadesContext.getStatementContext().getTableId(relation.getTable()).asInt())); + BitSet relationIdBitSetInCurrentCascadesContext = new BitSet(); + mvStructInfo.getRelations().forEach(relation -> { + tableBitSetInCurrentCascadesContext.set( + cascadesContext.getStatementContext().getTableId(relation.getTable()).asInt()); + relationIdBitSetInCurrentCascadesContext.set(relation.getRelationId().asInt()); + }); Review Comment: the BitSet of `tableBitSetInCurrentCascadesContext` maybe very big because the table id > 1 million? you can use RoaringBitmap instead of -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org