jqcc commented on code in PR #606:
URL:
https://github.com/apache/doris-flink-connector/pull/606#discussion_r2153588630
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/deserialization/converter/DorisRowConverter.java:
##########
@@ -339,26 +339,40 @@ private RowData convertRowData(Map<String, ?> row,
LogicalType type) {
}
private static List<Object> convertArrayData(ArrayData array, LogicalType
type) {
+ LogicalType elementType = ((ArrayType) type).getElementType();
+ List<Object> values;
if (array instanceof GenericArrayData) {
- return Arrays.asList(((GenericArrayData) array).toObjectArray());
+ values = Arrays.asList(((GenericArrayData) array).toObjectArray());
Review Comment:
As my test, I found that it is necessary.
At the beginning, we have a `Flink batch job` that read `Iceberg` and write
`Doris`. We found that `flink` would generate `GenericArrayData` when reading
`Iceberg` list, so we adapted `GenericArrayData` and added the corresponding
unit test.
Later, in the integration test, when we tested using `DataGen` as the
source, we found that `flink` would generate `BinaryArrayData`, so we processed
`GenericArrayData` and `BinaryArrayData uniformly`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
