wangshuo128 commented on code in PR #11502:
URL: https://github.com/apache/doris/pull/11502#discussion_r938499277


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/stats/JoinEstimation.java:
##########
@@ -41,10 +43,11 @@ public class JoinEstimation {
      * Do estimate.
      */
     public static StatsDeriveResult estimate(StatsDeriveResult leftStats, 
StatsDeriveResult rightStats,

Review Comment:
   Maybe passing a whole join node as the parameter is more clear, rather than 
properties in join. 
   Split and handle equal-to join conditions inside the method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to