seawinde commented on code in PR #50411:
URL: https://github.com/apache/doris/pull/50411#discussion_r2149939079


##########
fe/fe-core/src/main/java/org/apache/doris/tablefunction/MetadataGenerator.java:
##########
@@ -643,6 +661,61 @@ private static TFetchSchemaTableDataResult 
workloadGroupsMetadataResult(TSchemaT
         return result;
     }
 
+    private static TFetchSchemaTableDataResult 
viewDependencyMetadataResult(TSchemaTableRequestParams params) {
+        if (!params.isSetCurrentUserIdent()) {
+            return errorResult("current user ident is not set.");
+        }
+        Collection<DatabaseIf<? extends TableIf>> allDbs = 
Env.getCurrentEnv().getInternalCatalog().getAllDbs();

Review Comment:
   if write `select * from information_schema.view_dependency where view_schema 
= 'test_view_dependency_db' order by view_catalog,view_schema,view_name` would 
this filter by col `view_schema`



##########
fe/fe-core/src/main/java/org/apache/doris/tablefunction/MetadataGenerator.java:
##########
@@ -643,6 +661,61 @@ private static TFetchSchemaTableDataResult 
workloadGroupsMetadataResult(TSchemaT
         return result;
     }
 
+    private static TFetchSchemaTableDataResult 
viewDependencyMetadataResult(TSchemaTableRequestParams params) {
+        if (!params.isSetCurrentUserIdent()) {
+            return errorResult("current user ident is not set.");
+        }
+        Collection<DatabaseIf<? extends TableIf>> allDbs = 
Env.getCurrentEnv().getInternalCatalog().getAllDbs();

Review Comment:
   if write `select * from information_schema.view_dependency where view_schema 
= 'test_view_dependency_db' order by view_catalog,view_schema,view_name` would 
this filter by col `view_schema`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to