gavinchou commented on code in PR #51708:
URL: https://github.com/apache/doris/pull/51708#discussion_r2148982041
##########
cloud/src/common/bvars.cpp:
##########
@@ -186,4 +188,180 @@ BvarStatusWithTag<int64_t>
g_bvar_inverted_checker_abnormal_delete_bitmaps("chec
BvarStatusWithTag<int64_t>
g_bvar_inverted_checker_delete_bitmaps_scanned("checker",
"delete_bitmap_keys_scanned");
BvarStatusWithTag<int64_t>
g_bvar_max_rowsets_with_useless_delete_bitmap_version("checker",
"max_rowsets_with_useless_delete_bitmap_version");
+// rpc kv rw count
Review Comment:
seems lack of instance level stats
we may need to add `instance_id` a mbvar label.
##########
cloud/src/meta-service/meta_service_helper.h:
##########
@@ -232,16 +233,23 @@ inline MetaServiceCode cast_as(TxnErrorCode code) {
brpc::ClosureGuard closure_guard(done);
\
[[maybe_unused]] std::stringstream ss;
\
[[maybe_unused]] MetaServiceCode code = MetaServiceCode::OK;
\
+ [[maybe_unused]] std::unique_ptr<Transaction> txn;
\
[[maybe_unused]] std::string msg;
\
[[maybe_unused]] std::string instance_id;
\
[[maybe_unused]] bool drop_request = false;
\
+ [[maybe_unused]] KVStats stats(g_bvar_rpc_kv_##func_name##_read_counter,
\
+ g_bvar_rpc_kv_##func_name##_write_counter);
\
std::unique_ptr<int, std::function<void(int*)>> defer_status((int*)0x01,
[&](int*) { \
response->mutable_status()->set_code(code);
\
response->mutable_status()->set_msg(msg);
\
finish_rpc(#func_name, ctrl, response);
\
closure_guard.reset(nullptr);
\
if (config::use_detailed_metrics && !instance_id.empty() &&
!drop_request) { \
Review Comment:
does dropped request has any attached metrics?
if no, we should add one
##########
cloud/src/meta-service/mem_txn_kv.h:
##########
@@ -29,6 +30,7 @@
#include <unordered_map>
#include <vector>
+#include "common/stats.h"
Review Comment:
what is this for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
