morrySnow commented on code in PR #11513:
URL: https://github.com/apache/doris/pull/11513#discussion_r937642430
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/util/SlotExtractor.java:
##########
@@ -49,24 +47,24 @@ public static Set<Slot> extractSlot(Collection<Expression>
expressions) {
* extract slot reference.
*/
public static Set<Slot> extractSlot(Expression... expressions) {
-
- Set<Slot> slots = Sets.newLinkedHashSet();
+ Set<Slot> slots = Sets.newHashSet();
for (Expression expression : expressions) {
slots.addAll(extractSlot(expression));
}
return slots;
}
- private static List<Slot> extractSlot(Expression expression) {
- List<Slot> slots = Lists.newArrayList();
- new SlotExtractor().visit(expression, slots);
+ private static Set<Slot> extractSlot(Expression expression) {
+ Set<Slot> slots = Sets.newHashSet();
+ new SlotCollector().visit(expression, slots);
Review Comment:
maybe init a static singleton SlotCollector is better
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/util/SlotExtractor.java:
##########
@@ -49,24 +47,24 @@ public static Set<Slot> extractSlot(Collection<Expression>
expressions) {
* extract slot reference.
*/
public static Set<Slot> extractSlot(Expression... expressions) {
-
- Set<Slot> slots = Sets.newLinkedHashSet();
+ Set<Slot> slots = Sets.newHashSet();
for (Expression expression : expressions) {
slots.addAll(extractSlot(expression));
}
return slots;
}
- private static List<Slot> extractSlot(Expression expression) {
- List<Slot> slots = Lists.newArrayList();
- new SlotExtractor().visit(expression, slots);
+ private static Set<Slot> extractSlot(Expression expression) {
Review Comment:
if this function is private, i think `void extractSlot(Expression
expression, Set<Slot>)` maybe better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
