gavinchou commented on code in PR #51175:
URL: https://github.com/apache/doris/pull/51175#discussion_r2142650776


##########
be/src/cloud/cloud_storage_engine.cpp:
##########
@@ -321,13 +335,23 @@ Status 
CloudStorageEngine::start_bg_threads(std::shared_ptr<WorkloadGroup> wg_sp
     return Status::OK();
 }
 
-void CloudStorageEngine::sync_storage_vault() {
+void CloudStorageEngine::sync_storage_vault(bool check_storage_vault) {
     cloud::StorageVaultInfos vault_infos;
     bool enable_storage_vault = false;
-    auto st = _meta_mgr->get_storage_vault_info(&vault_infos, 
&enable_storage_vault);
-    if (!st.ok()) {
-        LOG(WARNING) << "failed to get storage vault info. err=" << st;
-        return;
+    auto st = Status::OK();
+    while (true) {
+        st = _meta_mgr->get_storage_vault_info(&vault_infos, 
&enable_storage_vault);

Review Comment:
   there is no connectivity for this get function



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to