gavinchou commented on code in PR #51617:
URL: https://github.com/apache/doris/pull/51617#discussion_r2142573318
##########
be/src/agent/task_worker_pool.cpp:
##########
@@ -1563,48 +1616,27 @@ void create_tablet_callback(StorageEngine& engine,
const TAgentTaskRequest& req)
}
});
DorisMetrics::instance()->create_tablet_requests_total->increment(1);
- VLOG_NOTICE << "start to create tablet " << create_tablet_req.tablet_id;
-
std::vector<TTabletInfo> finish_tablet_infos;
- VLOG_NOTICE << "create tablet: " << create_tablet_req;
- Status status = engine.create_tablet(create_tablet_req, profile);
+ Status status = check_tablet_limit();
+ if (status.ok()) {
+ VLOG_NOTICE << "start to create tablet " << create_tablet_req;
+ status =
+ create_tablet_and_get_info(engine, create_tablet_req, profile,
finish_tablet_infos);
+ }
+
if (!status.ok()) {
DorisMetrics::instance()->create_tablet_requests_failed->increment(1);
- LOG_WARNING("failed to create tablet, reason={}", status.to_string())
+ LOG_WARNING("failed to create tablet: {}", status.to_string())
.tag("signature", req.signature)
.tag("tablet_id", create_tablet_req.tablet_id)
.error(status);
} else {
- increase_report_version();
- // get path hash of the created tablet
- TabletSharedPtr tablet;
- {
- SCOPED_TIMER(ADD_TIMER(profile, "GetTablet"));
- tablet =
engine.tablet_manager()->get_tablet(create_tablet_req.tablet_id);
- }
- DCHECK(tablet != nullptr);
- TTabletInfo tablet_info;
- tablet_info.tablet_id = tablet->table_id();
- tablet_info.schema_hash = tablet->schema_hash();
- tablet_info.version = create_tablet_req.version;
- // Useless but it is a required field in TTabletInfo
- tablet_info.version_hash = 0;
- tablet_info.row_count = 0;
- tablet_info.data_size = 0;
- tablet_info.__set_path_hash(tablet->data_dir()->path_hash());
- tablet_info.__set_replica_id(tablet->replica_id());
- finish_tablet_infos.push_back(tablet_info);
- LOG_INFO("successfully create tablet")
+ LOG_INFO("successfully created tablet")
Review Comment:
also print some useful info like tablet id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
