yiguolei commented on code in PR #51486: URL: https://github.com/apache/doris/pull/51486#discussion_r2141642033
########## be/src/vec/data_types/serde/data_type_datetimev2_serde.cpp: ########## @@ -36,6 +37,30 @@ namespace doris::vectorized { static const int64_t micr_to_nano_second = 1000; #include "common/compile_check_begin.h" +Status DataTypeDateTimeV2SerDe::serialize_column_to_text(const IColumn& column, int64_t row_num, + BufferWritable& bw) const { + DataTypeSerDe::write_left_quotation(bw); + UInt64 int_val = assert_cast<const ColumnDateTimeV2&>(column).get_element(row_num); Review Comment: 这个函数接口是单个元素到stream 里,我们这个assert cast,默认是要检查类型是否一样的,会不会性能很差? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org