morningman commented on code in PR #51376:
URL: https://github.com/apache/doris/pull/51376#discussion_r2139105823
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/IcebergExternalTable.java:
##########
@@ -87,7 +96,11 @@ public void setTable(Table table) {
@Override
public Optional<SchemaCacheValue> initSchema(SchemaCacheKey key) {
- return IcebergUtils.loadSchemaCacheValue(catalog, dbName, name,
((IcebergSchemaCacheKey) key).getSchemaId());
+ boolean isView = isView();
+ String remoteDbName = getRemoteDbName();
Review Comment:
can fix in other PR
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HMSExternalTable.java:
##########
@@ -1188,4 +1189,10 @@ public List<SysTable> getSupportedSysTables() {
return Lists.newArrayList();
}
}
+
+ @Override
+ public boolean isTable() {
Review Comment:
can remove this
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/source/IcebergApiSource.java:
##########
@@ -42,6 +42,9 @@ public class IcebergApiSource implements IcebergSource {
public IcebergApiSource(IcebergExternalTable table, TupleDescriptor desc,
Map<String, ColumnRange> columnNameToRange) {
+ if (table.isView()) {
Review Comment:
Plz add comment
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HMSExternalTable.java:
##########
@@ -1188,4 +1189,10 @@ public List<SysTable> getSupportedSysTables() {
return Lists.newArrayList();
}
}
+
+ @Override
+ public boolean isTable() {
Review Comment:
Looks like no one call this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
