adonis0147 commented on code in PR #11400:
URL: https://github.com/apache/doris/pull/11400#discussion_r935328844
##########
be/CMakeLists.txt:
##########
@@ -517,7 +517,7 @@ set(CXX_FLAGS_DEBUG "${CXX_GCC_FLAGS} -O0")
# -O3: Enable all compiler optimizations
# -DNDEBUG: Turn off dchecks/asserts/debug only code.
set(CXX_FLAGS_RELEASE "${CXX_GCC_FLAGS} -O3 -DNDEBUG")
-SET(CXX_FLAGS_ASAN "${CXX_GCC_FLAGS} -O0 -fsanitize=address
-DADDRESS_SANITIZER")
+SET(CXX_FLAGS_ASAN "${CXX_GCC_FLAGS} -O3 -fsanitize=address
-DADDRESS_SANITIZER")
Review Comment:
> The default asan use O0, it is very slow. I think the better method it to
use O3, then in most cases, it is very quickly to run both ut and P0. If the
developer find the bugs, then he or she could change the default value then run
it again.
It is not a big deal, we can add an argument or an environment variable to
the build.sh to control it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
