yiguolei commented on code in PR #51282:
URL: https://github.com/apache/doris/pull/51282#discussion_r2122470291


##########
be/src/cloud/cloud_schema_change_job.cpp:
##########
@@ -83,6 +83,14 @@ Status CloudSchemaChangeJob::process_alter_tablet(const 
TAlterTabletReqV2& reque
     std::unique_lock 
schema_change_lock(_base_tablet->get_schema_change_lock(), std::defer_lock);
     bool owns_lock = 
schema_change_lock.try_lock_for(std::chrono::seconds(TRY_LOCK_TIMEOUT));
 
+    _new_tablet->set_alter_failed(false);
+    Defer defer([this] {
+        // if tablet state is not TABLET_RUNNING when return, indicates that 
alter has failed.
+        if (_new_tablet->tablet_state() != TABLET_RUNNING) {

Review Comment:
   这个是在fix bug 么?
   如果是,就单独提一个pr



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to