morningman commented on code in PR #51384:
URL: https://github.com/apache/doris/pull/51384#discussion_r2119244608


##########
be/src/vec/exec/format/table/iceberg/arrow_schema_util.cpp:
##########
@@ -70,7 +70,9 @@ Status ArrowSchemaUtil::convert_to(const 
iceberg::NestedField& field,
         break;
 
     case iceberg::TypeID::TIMESTAMP: {
-        arrow_type = 
std::make_shared<arrow::TimestampType>(arrow::TimeUnit::MICRO, timezone);
+        iceberg::TimestampType* t_type = 
static_cast<iceberg::TimestampType*>(field.field_type());

Review Comment:
   Please add regression test cases 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to