HappenLee commented on code in PR #51228:
URL: https://github.com/apache/doris/pull/51228#discussion_r2115241409
##########
be/src/pipeline/exec/analytic_sink_operator.cpp:
##########
@@ -194,16 +195,19 @@ Status AnalyticSinkLocalState::close(RuntimeState* state,
Status exec_status) {
bool AnalyticSinkLocalState::_get_next_for_sliding_rows(int64_t batch_rows,
int64_t
current_block_base_pos) {
- while (_current_row_position < _partition_by_pose.end) {
- int64_t current_row_start = 0;
+ int64_t remain_size = batch_rows - current_pos_in_block();
+ while (_current_row_position < _partition_by_pose.end && remain_size > 0) {
+ int64_t current_row_start = _current_row_position + _rows_start_offset;
int64_t current_row_end = _current_row_position + _rows_end_offset + 1;
+ const bool is_n_following_frame = _rows_end_offset > 0;
Review Comment:
the line should out of while loop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
