yiguolei commented on code in PR #51340:
URL: https://github.com/apache/doris/pull/51340#discussion_r2113283059
##########
be/src/vec/columns/column_vector.h:
##########
@@ -139,7 +139,11 @@ class ColumnVector final : public COWHelper<IColumn,
ColumnVector<T>> {
using Container = PaddedPODArray<value_type>;
ColumnVector() = default;
- ColumnVector(const size_t n) : data(n) {}
+
+ // for column boolean, must have initial value!
+ ColumnVector(const size_t n)
+ requires requires { !std::is_same_v<T, UInt8>; }
+ : data(n) {}
ColumnVector(const size_t n, const value_type x) : data(n, x) {}
Review Comment:
And also should modify resize method, to require boolean type has to call
resize_fill method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
