HappenLee commented on code in PR #48720:
URL: https://github.com/apache/doris/pull/48720#discussion_r2111225070
##########
be/src/pipeline/shuffle/writer.h:
##########
@@ -31,9 +31,18 @@ namespace pipeline {
#include "common/compile_check_begin.h"
class ExchangeSinkLocalState;
-class Writer {
+class WriterBase {
public:
- Writer() = default;
+ WriterBase() = default;
+
+protected:
+ template <typename ChannelPtrType>
+ void _handle_eof_channel(RuntimeState* state, ChannelPtrType channel,
Status st) const;
+};
+
+class TrivialWriter : public WriterBase {
Review Comment:
should be `final`
##########
be/src/pipeline/shuffle/writer.h:
##########
@@ -44,9 +53,28 @@ class Writer {
std::vector<std::shared_ptr<vectorized::Channel>>& channels,
size_t partition_count, const ChannelIdType*
__restrict channel_ids,
size_t rows, vectorized::Block* block, bool eos)
const;
+};
- template <typename ChannelPtrType>
- void _handle_eof_channel(RuntimeState* state, ChannelPtrType channel,
Status st) const;
+// maybe auto partition
+class OlapWriter : public WriterBase {
Review Comment:
should be final
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
