Jibing-Li commented on code in PR #51192:
URL: https://github.com/apache/doris/pull/51192#discussion_r2109413672
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HMSExternalTable.java:
##########
@@ -444,17 +444,21 @@ public long getCreateTime() {
private long getRowCountFromExternalSource() {
long rowCount = UNKNOWN_ROW_COUNT;
- switch (dlaType) {
- case HIVE:
- rowCount = StatisticsUtil.getHiveRowCount(this);
- break;
- case ICEBERG:
- rowCount = IcebergUtils.getIcebergRowCount(getCatalog(),
getDbName(), getName());
- break;
- default:
- if (LOG.isDebugEnabled()) {
- LOG.debug("getRowCount for dlaType {} is not supported.",
dlaType);
- }
+ try {
+ switch (dlaType) {
+ case HIVE:
+ rowCount = StatisticsUtil.getHiveRowCount(this);
+ break;
+ case ICEBERG:
+ rowCount = IcebergUtils.getIcebergRowCount(getCatalog(),
getDbName(), getName());
+ break;
+ default:
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("getRowCount for dlaType {} is not
supported.", dlaType);
+ }
+ }
+ } catch (Exception e) {
+ LOG.info("Failed to get row count for table {}.{}.{}",
getCatalog().getName(), getDbName(), getName(), e);
Review Comment:
It's on purpose to catch all Exception and log use info. Because it is not a
fatal or quite important message, use INFO is good enough, I don't want to
cause panic for the users. Also, it is on purpose to catch all exceptions, so
that we can continue try to use file size to estimate the row count.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
