morrySnow commented on code in PR #48317:
URL: https://github.com/apache/doris/pull/48317#discussion_r2108707435
##########
fe/fe-core/src/test/java/org/apache/doris/nereids/properties/UniqueTest.java:
##########
@@ -69,7 +69,7 @@ void testAgg() {
Assertions.assertTrue(plan.getLogicalProperties().getTrait()
.isUnique(plan.getOutput().get(0)));
plan = PlanChecker.from(connectContext)
- .analyze("select id, sum(id), avg(id), max(id), min(id) from
agg group by id")
+ .analyze("select id, sum(id), avg(id), max(id), min(id),
topn(id,2) from agg group by id")
Review Comment:
need to add assert below?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/EliminateGroupBy.java:
##########
@@ -46,54 +64,99 @@
* Eliminate GroupBy.
*/
public class EliminateGroupBy extends OneRewriteRuleFactory {
+ private static final ImmutableSet<Class<? extends Expression>>
supportedBasicFunctions
Review Comment:
use UPPER_CASE name format
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
