924060929 commented on code in PR #51270:
URL: https://github.com/apache/doris/pull/51270#discussion_r2108457236
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/types/TimeV2Type.java:
##########
@@ -57,6 +64,28 @@ public boolean equals(Object o) {
return o instanceof TimeV2Type;
}
+ //TODO: implement this method by parsing the string and get the scale of it
+ public static TimeV2Type forTypeFromString(String s) {
+ return MAX;
Review Comment:
you should implement this function, or else the result will different after
implement it.
for example
```sql
select time '11:12:13.123456' = time '11:12:13.12' -- should return false
```
so you should better implement this function in this pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
