yiguolei commented on code in PR #51271: URL: https://github.com/apache/doris/pull/51271#discussion_r2108081353
########## be/src/olap/rowset/segment_v2/segment.cpp: ########## @@ -1231,4 +1232,50 @@ StoragePageCache::CacheKey Segment::get_segment_footer_cache_key() const { _file_reader->size() - 12); } +std::map<uint32_t, Segment::ZoneMapInfo> Segment::get_zone_maps() const { + if (!config::enable_rowset_zone_map_cache || config::cache_zone_map_max_columns_count == 0) { Review Comment: 看着你这个写法,感觉这两个参数是一个参数啊。。。 比如这个count <= 0,表示禁止,>0 表示开启? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org